Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the strickthough position is wrong when fontsize is different #1919

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: the strickthough position is wrong when fontsize is different #1919

merged 1 commit into from
Apr 17, 2024
+4 −4

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Apr 15, 2024

close #1905

@Jocs Jocs marked this pull request as ready for review April 15, 2024 13:07
@Jocs Jocs requested review from DR-Univer and wzhudev as code owners April 15, 2024 13:07
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 15, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Apr 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 29.78%. Comparing base (db88447) to head (e4759f0).
Report is 7 commits behind head on dev.

Files Patch % Lines
...gine-render/src/components/docs/extensions/line.ts 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #1919   +/-   ##
=======================================
  Coverage   29.78%   29.78%           
=======================================
  Files        1173     1173           
  Lines       64012    64012           
  Branches    13598    13598           
=======================================
  Hits        19069    19069           
  Misses      44943    44943

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 17, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 17, 2024
@Jocs Jocs merged commit 2564456 into dev Apr 17, 2024
8 checks passed
@Jocs Jocs deleted the fix/strickthough branch April 17, 2024 11:01
Gggpound pushed a commit that referenced this pull request Apr 22, 2024
@Jocs @Gggpound
fix: the strickthough position is wrong when fontsize is different (#…
85b1668 
…1919)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gggpound Gggpound Gggpound approved these changes

@DR-Univer DR-Univer Awaiting requested review from DR-Univer

@wzhudev wzhudev Awaiting requested review from wzhudev

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] The position of the strikethrough is incorrect
3 participants
@Jocs @Gggpound @zhaolixin7